Skip to content

Fix update handlers failing on unlabeled CronJobs/Jobs - #939

Open
tomach wants to merge 2 commits into
masterfrom
ta/fix-unlabeled-backup-jobs
Open

tomach wants to merge 2 commits into
masterfrom
ta/fix-unlabeled-backup-jobs

Conversation

@tomach

@tomach tomach commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

Kubernetes returns metadata.labels = None for objects without labels. Since BeforeClusterUpdateSubHandler lists all CronJobs/Jobs in the namespace, a single unlabeled one raised AttributeError and blocked cluster updates.

  • Original fix by an external contributor, commit kept as-is (supersedes fix null pointer #937)
  • Added changelog entry
  • Added unit tests for both handlers

Checklist

kddrftedgh and others added 2 commits November 20, 2026 15:43
@tomach
tomach force-pushed the ta/fix-unlabeled-backup-jobs branch from 68f13b9 to 8d8cf83 Compare November 20, 2026 14:44
@tomach tomach mentioned this pull request Nov 20, 2026
1 of 5 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants