Skip to content

Update user password secret only when the secret's data changes - #935

Merged
plaharanne merged 1 commit into
masterfrom
p/password-update-no-label
Nov 17, 2026
Merged

plaharanne merged 1 commit into
masterfrom
p/password-update-no-label

Conversation

@plaharanne

@plaharanne plaharanne commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary of changes

Adding/Removing a label from a Kubernetes Secret trigger the password update handler.
In this PR, kopf.on.update targets the field "data" only.

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/3160
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@tomach tomach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@plaharanne
plaharanne merged commit 7618987 into master Nov 17, 2026
16 checks passed
@plaharanne
plaharanne deleted the p/password-update-no-label branch November 17, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants