Repository navigation
Allow configuring the CP resource base URL - #204
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain, and all reviewers assessed it as ready.
Review effort: Lite
Findings: None
What changed in this PR
Adds configurable CP resource URLs with CDN fallback, updates configuration documentation, and deprecates legacy preview-domain APIs.
Changes:
- Adds
resourceBaseUrland environment-variable support. - Preserves
previewDomaincompatibility while marking it deprecated. - Documents revised and read-only configuration settings.
| File | Summary |
|---|---|
src/fs/CpResourcesFs.php |
Applies the configured resource base URL. |
src/Config.php |
Defines the new setting and deprecates preview-domain APIs. |
README.md |
Documents configuration changes and managed settings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
resourceBaseUrl/CRAFT_CLOUD_RESOURCE_BASE_URLto override CP resource URLs, retaining the CDN fallback when unset. Clean up configuration docs and deprecate the unused preview-domain setting/helper.Validation: targeted URL/config checks, syntax, ECS, and Thermos passed. Full suite not run locally.