Repository navigation
dbus: suppress duplicate SubState subscriber updates - #532
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
SetSubStateSubscriber could flood updateCh with identical repeats (e.g. thousands of "dead" events/sec after a unit stops) because every PropertiesChanged path re-emitted the current SubState. Remember the last emitted SubState per unit and only send when it changes. Fixes coreos#502 Signed-off-by: Jason Wang <vulragrag@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SetSubStateSubscribercan floodupdateChwith identical repeats (e.g. thousands of"dead"events per second after a unit stops) because everyPropertiesChangedpath re-emits the current SubState even when it has not changed.Remember the last emitted SubState per unit and only send an update when it changes.
Fixes
Fixes #502
Signed-off-by
Signed-off-by: Jason Wang vulragrag@gmail.com