Repository navigation
fix: prevent stale animations from overriding update('none') - #12332
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes Agent Signed-off-by: sergioperezcheco <checo520@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update('none')writes the new element positions directly, but an animation already targeting those elements can overwrite them on its next frame. This cancels the affected dataset's element and option animations before applying the non-animated update, including shared options, while leaving other datasets' animations running.Fixes #11957. The regression tests cover line, scatter and bar charts, mixed per-dataset update modes, shared options, and an actual asynchronous render cycle. The same tests fail on unchanged production code; the focused suite, JavaScript lint, production build, API type checks and five integration projects pass locally. The full browser suite retains seven image-fixture failures reproduced on the baseline; one focused run also hit existing timing-sensitive shared-option assertions before a successful rerun. Firefox and the cross-platform CI matrix were not run locally.
Prepared and tested with Hermes Agent on behalf of Checo.