Repository navigation
fix(navigation): unseen badges line up in the menu, and a rail press opens a lobby only from an organization page - #1809
Merged
Merged
Conversation
… another organization's page On home, account or system pages no organization's page stays behind the menu, so a press on an organization button, or a pick in the phone switcher, opens that organization's menu sheet alone and the page stays. From another organization's page it still opens the lobby, which keeps the rail's current organization and the menu's organization the same. Co-Authored-By: Claude <noreply@anthropic.com>
…no width again Since #1805 the buttons beside a section toggle folded with a `0fr` grid track. The track keeps the min-content width of a fixed-width item, so each folded button still took 40px and a folded toggle ended short of its row. Apps with collapsible sections (several channel section types) showed it. The wrapper now folds by width, from 0 to the icon button's size-10, and clips. The buttons' focus ring sits inside, as the toggle's already does. Co-Authored-By: Claude <noreply@anthropic.com>
A section toggle and the organization row put their chevron after the badge, so their badge ended 24 to 28px left of the badges on the rows below. The Hidden toggle already let its badge take the chevron's place and widened the chevron in on hover or focus. That rule now lives in FoldingChevron, which the section toggle, the Hidden toggle and the organization row share. A row without a badge, and an open section, keep their chevron. The section toggle drops the button's transparent border, which put its badge and label 1px in from the rows and from a non-collapsible section's label. Co-Authored-By: Claude <noreply@anthropic.com>
The muted badge counts rows a person put out of the way: the Hidden toggle, hidden and archived menu rows, hidden organizations in the switcher. A solid gray pill still drew the eye next to the primary badges; a muted fill with muted-foreground text reads as secondary and keeps the text above 4.5:1 in both themes. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes to the menu sheet, found in raak (organization buttons on the rail, several channel section types). One commit each:
20261111T1101-organization-lobbysays so.0frgrid track, which keeps a fixed-width item's 40px, so a folded section toggle ended short of its row. The wrapper now folds by width (w-0to the icon button'sw-10) and clips; the buttons' focus ring sits inside.FoldingChevron, shared by all three. The section toggle drops the button's transparent border, which put it 1px in.bg-muted text-muted-foreground, for hidden and archived rows, the Hidden toggle and hidden organizations in the switcher.Mocks behind the badge pick (B): https://claude.ai/artifact/BAcFogPNQubnq5SUeG2oxg
Verification
pnpm checkpasses. Driven headless on raak's dev stack with the same files:/homestays on/homewith the sheet open; from organization 1's page, a press on organization 2 opens/<tenant>/<org2>with its sheet.No breaking change: no app work, no alignment of its own.
Size
folding-chevron.tsx(the Hidden toggle's fold, now shared by three rows, sohidden-group.tsxshrinks) and the lobby guard (code +20, comments +2, blank +2).