Skip to content

fix(navigation): unseen badges line up in the menu, and a rail press opens a lobby only from an organization page - #1809

Merged
flipvh merged 4 commits into
mainfrom
fix/menu-badge-column
Nov 12, 2026
Merged

flipvh merged 4 commits into
mainfrom
fix/menu-badge-column

Conversation

@flipvh

@flipvh flipvh commented Nov 11, 2026

Copy link
Copy Markdown
Member

Four fixes to the menu sheet, found in raak (organization buttons on the rail, several channel section types). One commit each:

  • Lobby only from an organization page. On home, account or system pages a press on a rail organization, or a pick in the phone switcher, opens that organization's menu sheet and the page stays. From another organization's page it still opens the lobby (feat(navigation)!: a press on another organization opens its lobby, and menu, search and home rows say more with less #1799). The alignment 20261111T1101-organization-lobby says so.
  • Folded section buttons take no width again. refactor(frontend)!: one home per kind of motion: transitions for state, presets for motion/react, tw-animate-css gone #1805 folded the settings and create buttons with a 0fr grid track, which keeps a fixed-width item's 40px, so a folded section toggle ended short of its row. The wrapper now folds by width (w-0 to the icon button's w-10) and clips; the buttons' focus ring sits inside.
  • Every unseen badge ends on one line. Section toggles and the organization row put their chevron after the badge, 24 to 28px left of the row badges. The Hidden toggle's rule (the badge takes the chevron's place, the chevron widens in on hover or focus) moves into FoldingChevron, shared by all three. The section toggle drops the button's transparent border, which put it 1px in.
  • Muted count badge is softer. bg-muted text-muted-foreground, for hidden and archived rows, the Hidden toggle and hidden organizations in the switcher.

Mocks behind the badge pick (B): https://claude.ai/artifact/BAcFogPNQubnq5SUeG2oxg

Verification

pnpm check passes. Driven headless on raak's dev stack with the same files:

  • Folded toggle badges and row badges both end 24px from the sheet edge; with the pointer on a folded section its chevron is 24px wide and the badge moves to 49px.
  • Folded section wrappers measure 0px; open, 40px plus the 8px margin.
  • A rail press on /home stays on /home with the sheet open; from organization 1's page, a press on organization 2 opens /<tenant>/<org2> with its sheet.

No breaking change: no app work, no alignment of its own.

Size

Kind Files Added Removed Net
Source 6 +58 -34 +24
Docs 1 +5 -4 +1
Total 7 +63 -38 +25
  • Source: folding-chevron.tsx (the Hidden toggle's fold, now shared by three rows, so hidden-group.tsx shrinks) and the lobby guard (code +20, comments +2, blank +2).
  • Docs: one sentence in the lobby alignment for the narrower rule.

flipvh and others added 4 commits November 12, 2026 00:33
… another organization's page

On home, account or system pages no organization's page stays behind the menu, so a press on an
organization button, or a pick in the phone switcher, opens that organization's menu sheet alone and
the page stays. From another organization's page it still opens the lobby, which keeps the rail's
current organization and the menu's organization the same.

Co-Authored-By: Claude <noreply@anthropic.com>
…no width again

Since #1805 the buttons beside a section toggle folded with a `0fr` grid track. The track keeps the
min-content width of a fixed-width item, so each folded button still took 40px and a folded toggle
ended short of its row. Apps with collapsible sections (several channel section types) showed it.

The wrapper now folds by width, from 0 to the icon button's size-10, and clips. The buttons' focus
ring sits inside, as the toggle's already does.

Co-Authored-By: Claude <noreply@anthropic.com>
A section toggle and the organization row put their chevron after the badge, so their badge ended 24
to 28px left of the badges on the rows below. The Hidden toggle already let its badge take the
chevron's place and widened the chevron in on hover or focus. That rule now lives in FoldingChevron,
which the section toggle, the Hidden toggle and the organization row share. A row without a badge,
and an open section, keep their chevron.

The section toggle drops the button's transparent border, which put its badge and label 1px in from
the rows and from a non-collapsible section's label.

Co-Authored-By: Claude <noreply@anthropic.com>
The muted badge counts rows a person put out of the way: the Hidden toggle, hidden and archived menu
rows, hidden organizations in the switcher. A solid gray pill still drew the eye next to the primary
badges; a muted fill with muted-foreground text reads as secondary and keeps the text above 4.5:1 in
both themes.

Co-Authored-By: Claude <noreply@anthropic.com>
@flipvh
flipvh merged commit abaca0b into main Nov 12, 2026
14 checks passed
@flipvh
flipvh deleted the fix/menu-badge-column branch November 12, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant