tests: use os.linesep in the repo-info default assertions - #10442
Merged
ThomasWaldmann merged 1 commit intoSep 27, 2026
Merged
Conversation
On Windows, repo-info output lines end with CRLF, so the assertions expecting a trailing "\n" failed there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10442 +/- ##
==========================================
- Coverage 88.70% 88.66% -0.04%
==========================================
Files 103 103
Lines 19284 19284
Branches 3004 3004
==========================================
- Hits 17105 17099 -6
- Misses 1507 1515 +8
+ Partials 672 670 -2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
repo-infoassertions from #10438 expected lines ending in"\n", but on Windows the output uses CRLF, so 6 tests failed inwindows_tests(e.g. the 2.0.0b25 tag run). Useos.linesep, likecreate_cmd_test.pyalready does.🤖 Generated with Claude Code