Skip to content

saved_handler handles empty moves - #3136

Merged
ashtum merged 2 commits into
boostorg:developfrom
mzfr:fix/saved-handler-empty-move
Nov 14, 2026
Merged

ashtum merged 2 commits into
boostorg:developfrom
mzfr:fix/saved-handler-empty-move

Conversation

@mzfr

@mzfr mzfr commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #3135

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (77f5a66) to head (8b1383a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3136   +/-   ##
========================================
  Coverage    93.88%   93.88%           
========================================
  Files          176      176           
  Lines        13975    13977    +2     
========================================
+ Hits         13120    13123    +3     
+ Misses         855      854    -1     
Files with missing lines Coverage Δ
include/boost/beast/core/impl/saved_handler.ipp 100.00% <100.00%> (+16.12%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f5a66...8b1383a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashtum

ashtum commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the PR.

May I ask whether you encountered this issue through the Beast public API or while using beast::saved_handler directly?

fix boostorg#3135

Co-authored-by: Mohammad Nejati <ashtumashtum@gmail.com>
@ashtum
ashtum force-pushed the fix/saved-handler-empty-move branch from 107c1d6 to 11216a4 Compare November 13, 2026 11:55
@cppalliance-bot

cppalliance-bot commented Nov 13, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://3136.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-11-14 12:26:57 UTC

@mzfr

mzfr commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Hi, I found this while testing the beast::saved_handler directly. Since saved_handler is a documented public interface that may be empty, I tested its ordinary move ops. Please let me know if that is something that usually won't happen and if this is invalid operations to do

@ashtum

ashtum commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

Hi, I found this while testing the beast::saved_handler directly. Since saved_handler is a documented public interface that may be empty, I tested its ordinary move ops. Please let me know if that is something that usually won't happen and if this is invalid operations to do

No, it's fine. I was just wondering why our ASan builds in CI didn't catch this if it were reproducible through the public HTTP or WebSocket APIs.

@ashtum
ashtum force-pushed the fix/saved-handler-empty-move branch from 2dade01 to e18c8b0 Compare November 14, 2026 07:51
@ashtum
ashtum force-pushed the fix/saved-handler-empty-move branch from e18c8b0 to 8b1383a Compare November 14, 2026 12:16
@ashtum
ashtum merged commit 200ebae into boostorg:develop Nov 14, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving an empty saved_handler causes segmentation fault

3 participants