Repository navigation
CI: Report mypy errors as a warning only - #844
Merged
Merged
Conversation
The mypy step failed when mypy found errors, and only continue-on-error kept the check green, so GitHub also listed "Process completed with exit code 1" as an error annotation next to the warning. The step now records the failure in its output instead of failing, and the warning is issued when the output says it failed. The check passes as before, with the warning as its only annotation.
- Resolve the TODO(RC1) comments. The comparison of 7.0 and the release candidate (76 fits) finds no change that the notes do not describe, and the Compatibility section states the versions that were tested, from Python 3.10 with the minimum versions to Python 3.15 and the development versions. - Check every commit since 7.0 against the notes. Correct the PRs that some entries cite (#801 and #802 for the asset pricing fixes) and the scope of others (weights that 7.0 already rejected, the system results of #784, the cluster ids of #789, the coverage figures of the default bandwidth), and add the changes that were missing: HausmanTestResults, extra_df of the IV least-squares models, the constant of AbsorbingLS with drop_absorbed, NaN t-statistics with a standard error of 0, the degrees of freedom of FamaMacBeth, and smaller errors and API details. - Mention NormalTestStatistic, #842 and #843.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 198 198
Lines 37727 37727
Branches 2430 2430
=======================================
Hits 37608 37608
Misses 51 51
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mypy step failed when mypy found errors, and only continue-on-error kept
the check green, so GitHub also listed "Process completed with exit code 1"
as an error annotation next to the warning. The step now records the failure
in its output instead of failing, and the warning is issued when the output
says it failed. The check passes as before, with the warning as its only
annotation.