Repository navigation
fix: DisposeComponentsAsync disposes components while the dispatcher … - #1940
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses the reported race with regression coverage and no identified blocking issues; tests were not run.
0 open findings
What changed in this PR
Fixes #1939 so bUnit disposes rendered components even when the renderer’s dispatcher is busy.
Changes:
- Moves root-component snapshotting and clearing onto the dispatcher and revises disposal-task tracking.
- Adds a regression test that holds the dispatcher busy during disposal.
- Documents the fix in the changelog.
| File | Description |
|---|---|
| tests/bunit.tests/BunitContextTest.cs | Adds busy-dispatcher disposal coverage. |
| src/bunit/Rendering/BunitRenderer.cs | Fixes disposal ordering and task tracking. |
| CHANGELOG.md | Records the fix for #1939. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
linkdotnet
force-pushed
the
fix/1939
branch
2 times, most recently
from
October 16, 2026 08:21
e05a98d to
d8e4d84
Compare
…is busy (fixes #1939) Claude-Session: https://claude.ai/code/session_019HVpjMG4nkcwsQQXg2aegk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1939