chore: sync from internal (rie-private-to-public) - #189
Merged
Merged
Conversation
roger-zhangg
approved these changes
Sep 17, 2026
Vandita2020
reviewed
Sep 21, 2026
| * **If we adopt your change, we credit you in the release notes** for the version that ships it. | ||
|
|
||
| To send us a pull request, please: | ||
| So that we can act on a pull request, please: |
There was a problem hiding this comment.
This sentence opening seems abrupt in continuous reading. Let's have something that is direct sentence. For example:
"To help us act on your pull request, please:"
or
"When submitting a pull request, please:"
| 4. Commit to your fork using clear commit messages. | ||
| 5. Send us a pull request, answering any default questions in the pull request interface. | ||
| 1. Open an issue first to discuss any significant work -- we would hate for your time to be wasted on something we | ||
| cannot take. |
There was a problem hiding this comment.
Let's use "dislike" instead of "hate"
Vandita2020
approved these changes
Sep 21, 2026
carole-lavillonniere
added a commit
to localstack/lambda-runtime-init
that referenced
this pull request
Sep 22, 2026
Brings the fork up to aws/aws-lambda-runtime-interface-emulator@3ccddd7 (Update from upstream - 2026-09-17), covering four upstream syncs: 3ccddd7 Update from upstream - 2026-09-17 (aws#189) c622c06 Update from upstream - 2026-08-25 (aws#187) ddf2bc4 Update from upstream - 2026-07-31 (aws#182) a0f264a chore: sync from internal (rie-private-to-public) (aws#181) The fork had been on develop@391c3f1 since April, and a0f264a is why this matters now: it makes raptor.Server.Shutdown drain in-flight responses via httpServer.Shutdown instead of calling httpServer.Close(), which severed connections whose handler was still writing. That race is what failed the weekly release twice -- as `Post ...: EOF` in TestRie_InvokeFatalError, and as a 10m package timeout in TestRie_InvokeWaitingForInitError, where the invoke goroutine's require.NoError skipped its un-deferred wg.Done() and deadlocked the package. Both tests are green on this merge: 0 failures in 40 runs of the package under -race, against 10/10 hangs before it. Conflicts, all in files we customize: go.mod Kept our go 1.27.1 directive over upstream's 1.26.6. Makefile Kept our GO_VERSION derived from go.mod, and the nojsonv2 GOEXPERIMENT export. check-binaries.yml Took upstream's switch from robinraju/release-downloader release.yml to `gh release download`, and from softprops/action-gh-release to `gh release create`; kept our Renovate action bumps (checkout/setup-python v7). release.yml's trailing context had already moved to upstream's shape, so keeping ours there would not have parsed. integ-tests.yml Version bumps only; kept ours. Note for the next integration: the previous one (#92) landed as a single squashed commit, so its upstream parent was lost and git computed the merge base as the Go 1.24 bump from 2025 -- 48 conflicts, 36 of them spurious add/add on files that were already identical. This was resolved against the true base (391c3f1) using a local `git replace --graft`, giving the 5 real conflicts above. Merging this one with --ff, per README-LOCALSTACK step 7, records the upstream parent and stops the next integration needing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync from internal LambdaRIEGithubSource.
The sync branch is reset to
developon every run, so this PR is always a single-commit diff against the currentdevelopwith no accumulated divergence. Force-pushed by the pipeline — do not commit to this branch by hand.