GUACAMOLE-2333: Allow the RDP redirected-drive open-file limit to be raised without a rebuild - #714
Open
benjefferies wants to merge 1 commit into
Open
benjefferies wants to merge 1 commit into
benjefferies wants to merge 1 commit into
Conversation
…configured. Each RDP session currently caps redirected-drive opens at 128. Concurrent opens from directory listings, thumbnails, and copies can exhaust that table, after which new opens fail with ENFILE. Honour GUAC_RDP_FS_MAX_FILES so the limit can be raised without a rebuild, keeping 128 as the default. Co-authored-by: Cursor <cursoragent@cursor.com>
benjefferies
force-pushed
the
configurable-rdp-fs-max-files
branch
from
September 21, 2026 12:07
06e5410 to
f96409e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each RDP session currently allows at most 128 concurrent opens on the redirected drive. Directory listings, thumbnailers, and copies can fill that table. Further opens then fail with
ENFILE(File open refused (-1)), and the drive appears unusable until the session is reconnected.This change honours
GUAC_RDP_FS_MAX_FILESwhen allocating the per-session table so the limit can be raised without rebuilding guacd. The compiled default remains 128.What changed
GUAC_RDP_FS_MAX_FILESas a positive integer up to 4096Test plan
src/protocols/rdp/tests/fs/max_files.cGUAC_RDP_FS_MAX_FILES=1024allows more concurrent opensGUAC_RDP_FS_MAX_FILES=nopelogs a warning and keeps 128Fixes: https://issues.apache.org/jira/browse/GUACAMOLE-2333