Repository navigation
GH-55583: [C++] Export arrow_bundled_dependencies with install(TARGETS) - #55620
Open
AnuragRaut08 wants to merge 1 commit into
Open
AnuragRaut08 wants to merge 1 commit into
AnuragRaut08 wants to merge 1 commit into
Conversation
|
|
Member
|
Is this correct? PR code and description written by:
Reviewed before submission by:
Could you check CI failures? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, Arrow creates the
arrow_bundled_dependenciesandarrow_gcs_bundled_dependenciesimported targets manually in the installed CMake package configuration files.This makes the bundled dependency archives harder to manage through CMake's standard install and export mechanisms.
This change exports these archives as regular CMake targets using
install(TARGETS).What changes are included in this PR?
arrow_create_merged_static_lib()to create a real static library target and merge dependency archives using a post-build command.aws-c-commontarget.ArrowConfig.cmake.inandArrowGcsConfig.cmake.in.Are these changes tested?
Tested locally on Linux:
libarrow_bundled_dependencies.aarchive contains 48 members.cmake-formatpre-commit hook successfully.git diff --check.Not tested:
Are there any user-facing changes?
No. These changes affect the CMake build, installation, and package export behavior. There are no intended changes to Arrow's public APIs.
PR code and description written by:
Reviewed before submission by: