Repository navigation
Conversation
initial commit Default to dynamic linking Default to dynamic linking for ODBC if both shared and static libs are built, i.e., both `ARROW_BUILD_SHARED` and `ARROW_BUILD_STATIC` are set Update comments
ODBC has boost locale dependency
Verify that Arrow libraries are dynamically linked
alinaliBQ
marked this pull request as ready for review
November 13, 2026 22:58
alinaliBQ
requested review from
assignUser,
jonkeane,
kou,
lidavidm and
raulcd
as code owners
November 13, 2026 22:58
Collaborator
Author
kou
reviewed
Nov 15, 2026
Comment on lines
+533
to
+543
| - name: Check ODBC Dependency | ||
| run: | | ||
| # The ODBC driver should link Arrow libraries dynamically on Linux | ||
| lib="$(pwd)/build/cpp/release/libarrow_flight_sql_odbc.so" | ||
| ldd "${lib}" | ||
| for arrow_lib in libarrow libarrow_compute libarrow_flight libarrow_flight_sql; do | ||
| ldd "${lib}" | grep -Fq "${arrow_lib}.so" || { | ||
| echo "Error: ${arrow_lib} is not dynamically linked to ${lib}" | ||
| exit 1 | ||
| } | ||
| done |
Member
There was a problem hiding this comment.
We don't need this check here. Using shared library is important in deb/RPM packages not normal builds.
| # On macOS, always link Arrow libraries statically. | ||
| # On Windows and Linux, link Arrow libraries dynamically if the shared libraries are | ||
| # built, and statically otherwise. | ||
| if(NOT APPLE) |
Member
There was a problem hiding this comment.
How about using if(APPLE) ... else() ... endif() instead of if(NOT APPLE) ... else() ... endif() for readability? I want to avoid a negative condition such as if(NOT ...) as much as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See discussion in GH-55432
What changes are included in this PR?
libboost-locale-devtoci/docker/ubuntu-24.04-cpp.dockerfileas it is required dependency for ODBC. It is now required because we are no longer building the boost as bundle dependency in the CIAre these changes tested?
Yes. I tested with local docker to ensure Linux ODBC still works. Also tested in CI.
Are there any user-facing changes?
Yes, the ODBC driver will be linked dynamically to Arrow libraries on Arrow according to settings on
arrow.spec.in.Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: