Preserve namespace metadata on XPath attribute results - #137
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108.
XPath queries for namespaced attributes currently return a synthetic
AttributeNodewith its value and local name, but emptyPrefixandNamespaceURI. Copy those fields from theNodeNavigatorwhen creating the result. A regression test covers//@xlink:hrefand an ordinary unprefixed attribute.The new test failed on the current master branch and passes with this change.
go test ./... -count=1,go test -race ./... -count=1,go vet ./..., andgit diff --checkpass locally. Remote CI remains to be checked. Prepared with AI assistance and reviewed and tested before submission.