Repository navigation
Fix HTTP response charset parameter parsing - #3654
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Decode HTTP response bodies using the declared charset for Content-Type values such as
text/plain;charset=ISO-8859-1,charset="ISO-8859-1"and a charset followed by other parameters. Splitting the header on spaces either misses the charset or passes quotes/semicolons toCharset.forName.Does this pull request fix one issue?
Fixes #3652.
Describe how you did it
Split media-type parameters on semicolons outside quoted values, respect quoted-pair escapes while splitting, and match the charset parameter case-insensitively. Reset to the configured default when no usable charset is declared. Unsupported charsets still raise the existing explicit exception.
Describe how to verify it
mvn -pl sentinel-transport/sentinel-transport-simple-http -am -Dtest=SimpleHttpResponseTest,HttpEventTaskTest,CommandCenterTest -Dsurefire.failIfNoSpecifiedTests=false verify— 19 tests passed.SimpleHttpResponseTest— 10 tests passed.Special notes for reviews
Closed PR #1590 only added null checking; this change addresses parameter parsing. No new dependency or configuration option.
AI assistance: DeepSeek and Codex assisted implementation, tests and this description.