You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What does this implement/fix? Explain your changes.
Removed the redundant _fit method from GreedyGaussianSegmenter in aeon/segmentation/_ggs.py.
BaseSegmenter already defaults to fit_is_empty=True, and intermediate states are automatically reset at the start of find_change_points, making _fit dead code.
Added a unit test in aeon/segmentation/tests/test_ggs.py to verify that _fit is not implemented, fit_is_empty evaluates to True, and calling .fit() works without error.
Added myself to .all-contributorsrc.
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
None.
PR checklist
For all contributions
I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
I have added the following labels to this PR based on the title: .
I have added the following labels to this PR based on the changes made: . Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, please run pre-commit locally and push the fixes to your PR branch.
Don't hesitate to ask questions on the aeonDiscord channel if you have any.
PR CI actions
These checkboxes will add labels to enable or disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #3911
What does this implement/fix? Explain your changes.
_fitmethod fromGreedyGaussianSegmenterinaeon/segmentation/_ggs.py.BaseSegmenteralready defaults tofit_is_empty=True, and intermediate states are automatically reset at the start offind_change_points, making_fitdead code.aeon/segmentation/tests/test_ggs.pyto verify that_fitis not implemented,fit_is_emptyevaluates toTrue, and calling.fit()works without error..all-contributorsrc.Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
None.
PR checklist
For all contributions