You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[DEP] Deprecate dataset_name in favour of name in load_monster_dataset - #3988
What does this implement/fix? Explain your changes.
load_monster_dataset used dataset_name while the other dataset loaders (load_classification, load_regression, load_forecasting, load_anomaly_detection etc.) use name.
Following the deprecation policy:
Added name as the first parameter, so positional calls are unchanged.
dataset_name will still work but it will raise a FutureWarning, with a TODO to remove it in v1.8.0.
A ValueError is raised if no name is given, or if both name and dataset_name are passed.
The argument handling happens before any network call.
Updated the docstring and the existing test to use name instead of dataset_name.
Added an offline test for the argument errors and an overnight test for the FutureWarning.
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
Happy to change the removal version if a different one is preferred.
PR checklist
For all contributions
I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
I have added the following labels to this PR based on the title: .
I have added the following labels to this PR based on the changes made: . Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, please run pre-commit locally and push the fixes to your PR branch.
Don't hesitate to ask questions on the aeonDiscord channel if you have any.
PR CI actions
These checkboxes will add labels to enable or disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
The macOS 3.13 job failed because the hosted runner lost communication with the server (infrastructure issue, no test failures in the log). All other test runs pass.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datasetsDatasets and data loadersdeprecationThis issue is related to deprecation or removal of code
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #3407.
What does this implement/fix? Explain your changes.
load_monster_datasetuseddataset_namewhile the other dataset loaders (load_classification,load_regression,load_forecasting,load_anomaly_detectionetc.) usename.Following the deprecation policy:
nameas the first parameter, so positional calls are unchanged.dataset_namewill still work but it will raise aFutureWarning, with a TODO to remove it in v1.8.0.ValueErroris raised if no name is given, or if bothnameanddataset_nameare passed.nameinstead ofdataset_name.FutureWarning.Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
Happy to change the removal version if a different one is preferred.
PR checklist
For all contributions