Repository navigation
fix: preserve dashboard migration sites on deploy - #337
Merged
Merged
Conversation
Omit production and stage migration vars so keep_vars retains the dashboard-managed values instead of overwriting them with empty lists. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adobe-bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
## [1.16.2](v1.16.1...v1.16.2) (2026-11-05) ### Bug Fixes * preserve dashboard migration sites on deploy ([#337](#337)) ([47c01ea](47c01ea))
Collaborator
|
🎉 This PR is included in version 1.16.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Production and stage HLX6_MIGRATION_SITES are dashboard-managed. The existing top-level keep_vars=true preserves dashboard variables only when deployment config does not explicitly override them.
Remove the empty declarations from production and stage; retain dev and test defaults. Document ownership and restoration after the previous reset.
Validation
Wrangler deployment dry runs passed for production and stage, with no HLX6_MIGRATION_SITES binding supplied by the deployment config. No live deployment or dashboard changes performed.
The previously cleared value still needs restoring in the dashboard.