Repository navigation
Preserve Unicode URL characters and clean typographic quotes - #5425
Open
satiricalguru wants to merge 3 commits into
Open
satiricalguru wants to merge 3 commits into
satiricalguru wants to merge 3 commits into
Conversation
Fixes aboutcode-org#4475 AI-assisted: Codex assisted with investigation, implementation and local tests. Signed-off-by: Jatin Pandey <jatinjio1212@gmail.com>
Limit Unicode preservation to URL matches. Retain the existing punctuation cleanup and discard invisible formatting marks. Update four stored ignorable URL values to match extraction without changing the license texts. Signed-off-by: Jatin Pandey <jatinjio1212@gmail.com>
|
Took a look through the changes in Supporting Unicode in URLs for issue #4475 (like the Cyrillic and Slovak Wikipedia paths) is a great improvement. However, setting
Having to add percent-encoded sentence fragments and punctuation to |
Trim raw trailing Unicode punctuation and recover paired bare HTTP origins separated by CJK prose. Keep ordinary Unicode paths and align the stored URLs used by license clue filtering. Signed-off-by: Jatin Pandey <jatinjio1212@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4475
ScanCode truncates or transliterates URL paths such as the Slovak and Cyrillic Wikipedia links in the issue. Preserve Unicode characters through URL normalization so the output points to the original path.
Normalize typographic quotes, remove invisible formatting marks, and trim trailing Unicode punctuation. If CJK prose joins two bare HTTP links into one candidate, recover the pair when the second scheme and sentence punctuation identify it. Update the stored URLs used for license clue filtering.
Validation
Finder and clue-filter tests on Python 3.12: 69 passed and 2 existing expected failures. The two regressions for prose and punctuation fail against the previous finder implementation.
Full license ignorable-clue validation: 37,669 passed. The two failures are the same FSL assertions reported on upstream develop.
GitHub reported 31 passing checks. The failed Azure job reproduced the same two FSL assertions as upstream, which also caused its parent pipeline to fail.
Tasks
AI assistance: Codex assisted with investigation, implementation and local tests.