fix: redact --svc-param values in config show - #83
Open
ConnorMoss02 wants to merge 3 commits into
Open
ConnorMoss02 wants to merge 3 commits into
ConnorMoss02 wants to merge 3 commits into
Conversation
| sensitive := false | ||
| switch f.Name { | ||
| case "auth", "bearer", "api-key": | ||
| case "auth", "bearer", "api-key", "svc-param": |
Member
There was a problem hiding this comment.
how about doing a prefix check for svc-param, not all headers are sensitive. also let's remove bearer and api-key please, we decided to not add these to the cli
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback. Done. Only Authorization values are redacted now, and other headers show as-is. Removed bearer and api-key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config showprinted--svc-paramvalues, includingAuthorizationheaders, in clear text. Authorization entries now show asAuthorization=<redacted>, other headers stay visible, and the unusedbearerandapi-keynames are removed.Fixes #82