Repository navigation
separate settings + help from the calendar workspace - #222
Merged
Merged
Conversation
# Conflicts: # src/routes/(panel)/(calendar)/calendar/+page.svelte
Cattn
requested review from
miretskydatwit
and removed request for
jaspermayone
October 18, 2026 17:50
Collaborator
Author
|
This PR now has all of the major shell "refactors", and I left the actual UI changes in #218. As I want to merge this PR now to get these changes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings and Help currently live inside the Calendar page. This PR gives them their own routes so they can be used across modes without loading Calendar/Friends resources.
The existing pages are moved directly, their shared settings cache is separated from Calendar, and old links + returning to Settings after sign-in still work. Pending Calendar processing also stops safely when navigating away.
Calendar and Friends now share a nested route layout, keeping the same URLs and existing behavior. Account/environment resets stay shared, cached workspace state is retained, and Calendar polling stops when leaving the workspace. This includes the workspace refactor from #219.
The current header and Calendar, Friends, Settings, and Help tabs stay in place. The menu button and mode navigation are deferred to #218, which is stacked on this PR and should stay open until another mode such as Registration or Brightspace is ready. Merge this PR first to land the internal refactor independently.
Validation: 53 unit tests + 40 deterministic UI tests passed, along with Svelte/TypeScript checks and changed-file lint/formatting. Existing tests were updated for tab navigation; no new tests were added.