Skip to content

separate settings + help from the calendar workspace - #222

Merged
Cattn merged 9 commits into
mainfrom
refactor-extra-pages
Oct 18, 2026
Merged

Cattn merged 9 commits into
mainfrom
refactor-extra-pages

Conversation

@Cattn

@Cattn Cattn commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Settings and Help currently live inside the Calendar page. This PR gives them their own routes so they can be used across modes without loading Calendar/Friends resources.

The existing pages are moved directly, their shared settings cache is separated from Calendar, and old links + returning to Settings after sign-in still work. Pending Calendar processing also stops safely when navigating away.

Calendar and Friends now share a nested route layout, keeping the same URLs and existing behavior. Account/environment resets stay shared, cached workspace state is retained, and Calendar polling stops when leaving the workspace. This includes the workspace refactor from #219.

The current header and Calendar, Friends, Settings, and Help tabs stay in place. The menu button and mode navigation are deferred to #218, which is stacked on this PR and should stay open until another mode such as Registration or Brightspace is ready. Merge this PR first to land the internal refactor independently.

Validation: 53 unit tests + 40 deterministic UI tests passed, along with Svelte/TypeScript checks and changed-file lint/formatting. Existing tests were updated for tab navigation; no new tests were added.

@Cattn
Cattn requested a review from jaspermayone as a code owner October 16, 2026 16:48
@Cattn
Cattn added this pull request to stack #220 October 16, 2026 16:48
@Cattn
Cattn removed this pull request from stack #220 October 18, 2026 17:37
@Cattn
Cattn changed the base branch from refactor-shell-handling to main October 18, 2026 17:37
@Cattn
Cattn added this pull request to stack #234 October 18, 2026 17:37
@Cattn
Cattn requested review from miretskydatwit and removed request for jaspermayone October 18, 2026 17:50
@Cattn

Cattn commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator Author

This PR now has all of the major shell "refactors", and I left the actual UI changes in #218. As I want to merge this PR now to get these changes in

@miretskydatwit miretskydatwit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cattn
Cattn added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit 19bff66 Oct 18, 2026
2 checks passed
@miretskydatwit
miretskydatwit deleted the refactor-extra-pages branch October 23, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants