fix: replace deprecated fork icons - #1470
Closed
arnavtambe wants to merge 1 commit into
Closed
arnavtambe wants to merge 1 commit into
arnavtambe wants to merge 1 commit into
Conversation
Contributor
|
@arnavtambe is attempting to deploy a commit to the vetswhocode-web-app Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Hey @arnavtambe so all of this work was actually moved into another project, our closed source LMS, so this code has no wherer to go as we are ripping the profile section out. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced the undefined FontAwesome 4
fas fa-code-forkicon references with the FontAwesome 5-compatiblefas fa-code-branchicon.Type of Change
Related Issues
Closes #1465
Changes Made
fas fa-code-forktofas fa-code-branchinGitHubStatsGrid.tsx.fas fa-code-forktofas fa-code-branchinActivityFeed.tsx.Screenshots/Videos
Not applicable. This is an icon-only fix.
Testing
Test Configuration
Test Steps
fas fa-code-forkreferences were replaced.npx biome lint src/components/profile/GitHubStatsGrid.tsx src/components/profile/ActivityFeed.tsx.git diff --check.Results
npm run typecheckreports two pre-existing unrelated TypeScript errors insrc/pages/admin/users.tsxandsrc/pages/api/learn/progress.ts.Checklist
Code Quality
Testing
npm testnpm run typechecknpm run litAccessibility
Responsive Design
Performance
Security
Documentation
Additional Notes
This change only updates the FontAwesome icon class names and does not modify application logic or functionality.
For Reviewers
Focus areas:
fas fa-code-branchclass.Questions: