Skip to content

fix: replace deprecated fork icons - #1470

Closed
arnavtambe wants to merge 1 commit into
Vets-Who-Code:masterfrom
arnavtambe:fix/profile-fork-icon
Closed

arnavtambe wants to merge 1 commit into
Vets-Who-Code:masterfrom
arnavtambe:fix/profile-fork-icon

Conversation

@arnavtambe

Copy link
Copy Markdown

Description

Replaced the undefined FontAwesome 4 fas fa-code-fork icon references with the FontAwesome 5-compatible fas fa-code-branch icon.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update
  • Build/CI update

Related Issues

Closes #1465

Changes Made

  • Updated fas fa-code-fork to fas fa-code-branch in GitHubStatsGrid.tsx.
  • Updated fas fa-code-fork to fas fa-code-branch in ActivityFeed.tsx.
  • No other functionality was changed.

Screenshots/Videos

Not applicable. This is an icon-only fix.

Testing

Test Configuration

  • OS: Windows
  • Browser: Not applicable
  • Node version: Local project Node.js environment

Test Steps

  1. Verified both deprecated fas fa-code-fork references were replaced.
  2. Ran npx biome lint src/components/profile/GitHubStatsGrid.tsx src/components/profile/ActivityFeed.tsx.
  3. Ran git diff --check.

Results

  • Biome lint passed for both modified files.
  • Git diff check passed.
  • npm run typecheck reports two pre-existing unrelated TypeScript errors in src/pages/admin/users.tsx and src/pages/api/learn/progress.ts.

Checklist

Code Quality

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particulary in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Testing

  • I have tested on desktop
  • I have tested on mobile
  • I have tested on tablet
  • I have tested on multiple browseers (Chrome, Firefox, Safari)
  • All tests pass: npm test
  • TypeScript compiles: npm run typecheck
  • Linting passes: npm run lit

Accessibility

  • I have tested with a screen reader
  • All images have alt text
  • Color contrast meets WCAG AA standards
  • Keyboard navigation works
  • Focus indicators are visible

Responsive Design

  • Works on mobile (375px width)
  • Works on tablet (768px width)
  • Works on desktop (1440px width)
  • No horizontal scrolling on mobile

Performance

  • Images are optimized
  • No unnecessary re-renders
  • Bundle size impact is reasonable

Security

  • No sensitive data in code
  • API keys are in environment variables
  • Input validation is implemented
  • SQL injection prevention is in place (if applicable)
  • XSS prevention is in place

Documentation

  • README updated (if needed)
  • API documentation updated (if needed)
  • Component props documented (if new component)
  • CHANGELOG updated (if applicable)

Additional Notes

This change only updates the FontAwesome icon class names and does not modify application logic or functionality.

For Reviewers

Focus areas:

  • Verify that the fork icons now use the FontAwesome 5-compatible fas fa-code-branch class.
  • Verify that no other functionality was affected.

Questions:

  • None.

@vercel

vercel Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@arnavtambe is attempting to deploy a commit to the vetswhocode-web-app Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
vets-who-code-app Error Error Sep 29, 2026 8:10pm UTC

Request Review

@jeromehardaway

Copy link
Copy Markdown
Contributor

Hey @arnavtambe so all of this work was actually moved into another project, our closed source LMS, so this code has no wherer to go as we are ripping the profile section out.

This branch had an error being deployed

1 failed deployment
Preview — 51700973 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Fork icons render blank on the profile page

2 participants