Repository navigation
Conversation
clock_offset was cast to uint16_t before being formatted with %d, so a device in a time zone west of UTC reported 65531 instead of -5. The UI uses it to place the day plot, price plot and clock labels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🔧 PR Build ArtifactsVersion: All environments built successfully. Download the zip files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sysinfoJson()cast the UTC offset touint16_tbefore formatting it with%d, so a device west of UTC (e.g. UTC-5) reported"clock_offset": 65531. The UI usesclock_offsetto place the day plot, month plot, price plot and clock labels, so all of those would be wrong there.Fix
Cast to
int16_tinstead. It promotes tointfor%dand keeps the sign.Verification
65531with the old cast and-5with the new one; +2 h prints2with both.pio run -e esp32s2devbuilds.Found while fixing the DST label shift in #1297.
🤖 Generated with Claude Code