Skip to content

Add language/title in track selection - #506

Merged
arch1t3cht merged 1 commit into
TypesettingTools:masterfrom
moi15moi:Add-language/title-in-track-selection
Oct 6, 2026
Merged

arch1t3cht merged 1 commit into
TypesettingTools:masterfrom
moi15moi:Add-language/title-in-track-selection

Conversation

@moi15moi

Copy link
Copy Markdown
Contributor

This PR is a draft because i'm waiting for FFMS/ffms2#467 to be merged.
Note that ffmpeg doesn't expose the BCP language of mkv file (see: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21257). There might be a day a new field named language_bcp.

Before

Video track
image

Audio track
image

Now

Video track
image

Audio track
image

@arch1t3cht

Copy link
Copy Markdown
Member

I know it's still a draft, but if the upstream PR is merged this will still need an ifdef for the ffms2 version - this is also why the CI fails on Linux.

@moi15moi
moi15moi force-pushed the Add-language/title-in-track-selection branch from 182f0ce to f3f252f Compare January 7, 2026 00:18
@moi15moi

moi15moi commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@arch1t3cht Currently, this PR use this syntax Track ##: codec - [language] - Title

Do you believe I should add the channel count as requested in arch1t3cht#171

@moi15moi
moi15moi force-pushed the Add-language/title-in-track-selection branch from f3f252f to 521c8dd Compare April 9, 2026 23:20
@moi15moi
moi15moi marked this pull request as ready for review April 9, 2026 23:20
@moi15moi

moi15moi commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

The ffms2 PR have been merged, so this PR is now ready.

@arch1t3cht

Copy link
Copy Markdown
Member

Thanks!

@arch1t3cht
arch1t3cht merged commit 06d5f4b into TypesettingTools:master Oct 6, 2026
7 checks passed
@moi15moi
moi15moi deleted the Add-language/title-in-track-selection branch October 6, 2026 18:43
@moi15moi

moi15moi commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@arch1t3cht Currently, this PR use this syntax Track ##: codec - [language] - Title

Do you believe I should add the channel count as requested in arch1t3cht#171

I guess that means no.

@arch1t3cht

Copy link
Copy Markdown
Member

It's not like I'm against including the channel count, but this PR seemed fine to me as is and was already delayed long enough due to the 3.5 freeze so I merged it as is for now. The format can always be extended later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants