Security hardening: pickle -> json - #423
Merged
Merged
Conversation
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
hobu
reviewed
Sep 17, 2026
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
adamjstewart
commented
Sep 17, 2026
hobu
requested changes
Sep 18, 2026
hobu
left a comment
hobu
left a comment
Member
There was a problem hiding this comment.
I don't know if we should let users dynamically control this size limitation, but we should parameterize it to make it convenient to change.
Co-authored-by: Howard Butler <howard@hobu.co>
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Collaborator
Author
|
Reminder: double check for other places in the docs that mention pickle and document that only valid JSON objects are serializable. |
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
hobu
approved these changes
Sep 21, 2026
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
This was referenced Sep 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #420
@hobu @mwtoews I think I found a way to make json safe. This supports a much wider variety of types than manual str parsing, and should be unnoticeable for most users. The only difference found during testing is that tuples are replaced by lists, but that may not matter for most use cases. Arbitrary custom objects are no longer supported, but we could document this. If this looks good I can also add unit tests for this new error path.
Closes #420