Repository navigation
Conversation
1. Load all daily series with one request
Rules of the API for the
Fix:
2. The cache keeps failed time series (solved with 1)When Fix: Do not cache empty series. Alternatively, use a short cache lifetime for them. 3. A visits error also stops the visitors series (solved with 1)Both API calls are in the same Fix: Put each API call in its own 4. The sparkline axes show a false zero lineWithout Example: For the visits These calls use
Fix: Set 5. The "Register" button also closes the formThe chevron toggle and the "Register" button control the same details row. The click handler in Fix: Make the "Register" button open the row only. 6. The credit warnings are hiddenThe old Fix: Open the details row by default when Minor items7. The widget sends more API requestsOn a cache miss, the widget sends three API requests one after the other. Before the change, it sent one request. Item 1 partly fixes this. 8. The open and closed state is stored in different waysThe UI stores the open and closed state in three different ways:
Fix: Use one method for all three cases. 9. Unused CSS
Fix: Remove the two rules. 10. An interface changed
11. Two number formatsThe page module uses a narrow no-break space as the thousands separator. The widget uses 12. The toggle label has no contextThe toggle in each row has the same label: "Details". A screen reader reads the same text for each row. Fix: Add the site name to the label, for example "Details: {site.pageName}". 13. An
|
|
@sfsmfc Thanks for the review. All 13 points are in the last three commits. Over to you:
One thing to know: the API groups the |
…and page bar Data - Get views, visitors and bounce rate of the site from analytics/sessions and the time on page from the page view duration graph (same metric as the page module). Load totals, previous period and daily series with five parallel requests. - Query full UTC days in the widget and the page bar, so charts have no partial first day. - Do not cache missing current values; drop the trend when the previous period fails; drop the details when the series fails. - Put all extension caches into the group "pages", so cache:flush and the backend cache buttons flush them. Trends - Show trends from 0 and "±0" for unchanged values. - Show an info icon with an accessible tooltip when there is no value to compare with. Use the same rules in the page performance bar. - Name the percentage points of the bounce rate in the tooltip. Display - Format dates in the locale of the backend user. - Draw flat zero series on the baseline of charts with an explicit yMin. - Render the widget sparklines with a ViewHelper instead of the service. - Rename "Visits" to "Views" and "Avg. visit duration" to "Avg. time on page" in the widget; update the documentation.
…registration The API has no support for this choice yet, so the option always failed. A follow-up change adds the choice together with its implementation.
Reworks the backend views: the site list becomes a compact table with collapsed inactive sites, the register form asks whether an inactive site is registered as new or added to an existing active site, the page module gets an expandable panel with all metric details, and the Site Performance widget shows descriptions, daily values and sparklines for all four metrics.
analytics/sessionsrequest; widget charts fill the remaining card height; register form sends mode=register|attach (+ targetSiteIdentifier); new labels in en/de only