Skip to content

Style builder: other single-value slider labels can also target a disabled input (non-'auto' fields) #3454

Description

@vivi-the-going-merry

Follow-up from #3439/PR #3449 self-review (not blocking that PR - scoped there to Width/Height, the two fields that ship with a non-measured default).

Any single-value slider label following the <label for="{id}-value"> pattern in _buttons.php/_field-labels.php/_field-sizes.php/_general.php etc. points at a slider.php-rendered value input that renders disabled whenever its unit is non-measured (FrmSliderStyleComponent::is_measured_unit() - true only for px/em/%). A label pointing at a disabled input never receives focus on click - the same defect class #3449 fixes for Width/Height.

~20 other slider fields share the pattern (e.g. frm_font_size-value, frm_field_width-value, frm_title_size-value, frm_border_radius-value). None of them default to a non-measured unit today, so there's no live default-state bug for them yet - but a user can still manually clear a field's unit to blank ("", the "Not set" option every slider offers) and disable that field's own label the same way.

PR #3449 adds the mechanism to fix this (a data-slider-label-for marker + FrmSliderStyleComponent::is_value_measured() + JS updateLabelFocusTarget()) for exactly the two fields it targets. Extending the same data-slider-label-for/conditional-for treatment to the rest of these labels would close the gap generally.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions