Skip to content

SLE-1667 Use shared Gitar Renovate safety rule - #1160

Merged
nquinquenel merged 1 commit into
masterfrom
task/nq/deduplicate-gitar-renovate-rules
Nov 12, 2026
Merged

nquinquenel merged 1 commit into
masterfrom
task/nq/deduplicate-gitar-renovate-rules

Conversation

@nquinquenel

Copy link
Copy Markdown
Member

Use the shared Renovate safety automation from gitar-config#6 by removing the local .gitar/rules/renovate-safety.md override and the label-only renovate-major-minor package rule. The shared rule identifies eligible major/minor upgrades without labels.

Retains the integration-fixture exclusions; removes the now-empty packageRules array.

Validation:

  • Parsed the Renovate JSON and confirmed every remaining setting is unchanged. Checked for stale rule/label references and ran git diff --check.
  • DEEP Vortex attempted; unavailable because no project is configured in the isolated checkout.

Application builds are unnecessary for this configuration-only change. Static checks do not prove live shared-rule inheritance; an eligible Renovate PR is needed to verify the automation end to end.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Use shared Gitar Renovate safety rule SLE-1667 Use shared Gitar Renovate safety rule Nov 12, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

SLE-1667

@gitar-bot

gitar-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved 🟡 Medium risk

Removing the local Renovate rule changes major/minor upgrade eligibility, potentially triggering dependency updates without the previous label-based selection.

Removes the local .gitar/rules/renovate-safety.md override and the label-only renovate-major-minor package rule, switching to the shared Renovate safety rule from gitar-config. The integration-fixture exclusions are retained and the now-empty packageRules array is removed. No issues found.

Verification Rules 2/2 met PRs 1 inspected

Functional validation No results

Rules 2 passed 2 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact PRs 1 inspected
Cross-PR 1 PR inspected 0 open impacts

PR 2454: SLCORE-2763 Use shared Gitar Renovate safety rule Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nquinquenel
nquinquenel merged commit fc5dd12 into master Nov 12, 2026
39 of 40 checks passed
@nquinquenel
nquinquenel deleted the task/nq/deduplicate-gitar-renovate-rules branch November 12, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants