ECHOES-1284 A11y: Render the focus ring outside combined primary buttons - #778
david-cho-lerat-sonarsource wants to merge 1 commit into
Conversation
…ndicatorA11y: Render the focus ring outside combined primary buttons
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review ✅ Approved🟡 Medium risk · Combined primary buttons now layer visible focus rings above adjacent buttons. Adds Review coverage🧪 Functional validation 2 of 2 objectives covered 📋 Rules No rules evaluated Cross-repo inspection is incomplete. Unread code may contain additional impacts. 🤖 Auto-approval Not enabled · Set up Implementation Status ✅ 2 of 2 objectives covered✅ ECHOES-1284 - 2 of 2 objectives coveredThis PR covers the rendering of the focus ring outside combined primary buttons and ensuring the focus indicator contrast. ✅ 2 covered here
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|





Summary by Gitar
isolation: isolateandz-index: 1inButtonGroup.tsxThis will update automatically on new commits.
Visuals
Combined primary buttons, with the first button keyboard-focused.
echoes-react.netlify.appdeploy-preview-778--echoes-react.netlify.app