Repository navigation
deskflow@1.27.0: Clarify portable service limitations - #19118
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title follows the repository’s conventional format and clearly identifies the manifest and the change to its portable service notes. |
| Description check | |
The description explains the change, links it to issue #19117, reports validation and testing limits, and completes both required checklist items. |
| Linked Issues check | |
Issue #19117 requires the Deskflow manifest notes to explain that Scoop installs the portable build, that this build hides Windows background service options, and that users who need login-screen or U… |
| Out of Scope Changes check | |
The reported change adds only the requested installation notes in bucket/deskflow.json. The reviewed manifest shows the portable-build limitation and MSI direction. No unrelated changes are reported… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
Full details: Linked Issues check
-
Explanation
Issue
#19117requires the Deskflow manifest notes to explain that Scoop installs the portable build, that this build hides Windows background service options, and that users who need login-screen or UAC support should use the official MSI. The reviewed manifest contains both notes. The supplied PR summary reports three added lines and no removals.
Full details: Out of Scope Changes check
-
Explanation
The reported change adds only the requested installation notes in
bucket/deskflow.json. The reviewed manifest shows the portable-build limitation and MSI direction. No unrelated changes are reported.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
/verify |
|
All changes look good. Wait for review from human collaborators. deskflow
|
Closes #19117
Scoop installs Deskflow's portable build, which hides the Windows background service options, including login screen and UAC support. Add installation notes explaining this and directing users who need those features to the official MSI installer.
Upstream 1.27.0 hides the service options in portable mode; the MSI installs the service for secure desktops.
Validation: the staged manifest passes the current Scoop JSON schema and
git diff --cached --check. JSON formatting and CRLF line endings match the repository conventions. All existing notes and other manifest fields are preserved. Windows installation/Pester tests were not run locally (Linux host without PowerShell or Scoop).<manifest-name[@version]|chore>: <general summary of the pull request>