Repository navigation
Fix Currency.unregister before the currency table is loaded - #1238
Open
Shaisolaris wants to merge 2 commits into
Open
Shaisolaris wants to merge 2 commits into
Shaisolaris wants to merge 2 commits into
Conversation
sunny
previously approved these changes
Oct 12, 2026
RSpec/RepeatedExampleGroupDescription flagged the second describe ".unregister" block.
sunny
approved these changes
Oct 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Money::Currency.unregisterreads@tabledirectly, so it raises when it is the first call that touches the currency table, for example in an initializer right afterrequire "money":registerand the lookup methods all go throughtable, which loads the currencies on first use. This change makesunregisterusetableas well. When a currency is actually removed, it now also drops the cached instance and clears the iso_numeric index, asregisterdoes, so later lookups do not see stale entries.Tests:
.unregisterspecs inspec/money/currency_spec.rb. The two that start with an unloaded table fail on main withNoMethodErrorand pass with the change. The iso_numeric one passes on both and is there as a regression guard.rspec: 505 examples, 0 failures locally on Ruby 3.3.A CHANGELOG entry is added under Unreleased.