Repository navigation
Migration Engine: Copy the remaining required categories to SQL - #6156
Open
warwickschroeder wants to merge 2 commits into
Open
warwickschroeder wants to merge 2 commits into
warwickschroeder wants to merge 2 commits into
Conversation
…ntegration events, custom checks, failed error imports with their bodies, and group comments. With them, the offline copy covers all sixteen required categories.
rbev
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--start-data-migrationcopies the last four required categories from RavenDB to SQL: pending integration events, custom checks, failed error imports with their bodies, and group comments. With them, the offline copy covers all sixteen required categories.What this adds
--start-data-migration.MaxBodySizeToStoregoes to body storage before the transaction opens, and only for the row the insert keeps.SourceStorageCheck, a harmless reason, matched on id and category, so a customer or audit check reusing an id is copied., harmless.MessageFailedevent that is never sent; the instructions say where merged and changed rows are reported, anddocs/README.mdneeded no change.Tests
ServiceControl.Migration.AcceptanceTests: each new category end to end on SQL Server and PostgreSQL, the category summary separating changed and merged rows, a copied event dispatched once after a retry, the persister check skip by id and category, imported bodies replayed through the product's import path, and blank group comments left out as harmless.ServiceControl.Persistence.Tests/EFCore/Migration: the four writers and their row mappers, their skips, already present rows and merges, that custom checks and failed imports have no text column with a length limit, throughput days summed within and across batches, the retry reset's delete and its refusal after ServiceControl opened, a logged change or merge for each row stored differently, and retry claims copied only where held.ServiceControl.Persistence.Tests.RavenDB/DataMigration: the four readers, the persister checks flagged by id and category and matching the checks the persister registers, throughput read one endpoint per batch, and each retry-issued message flagged with whether RavenDB held its claim.ServiceControl.Persistence.Tests.SqlServer: throughput endpoints that differ only by accent are summed under an accent-insensitive key collation and reported as a merge.ServiceControl.Persistence.Tests.PostgreSql: a NUL character in a custom check or failed import is skipped as malformed and the rest copy.ServiceControl.UnitTests/Migration: every skip reason is exactly one of harmless, permanent or retryable, each harmless reason has its own explanation, and the refusal marks harmless reasons.