Skip to content

Disable retained SQL Server test full-text indexes - #6155

Open
rbev wants to merge 1 commit into
masterfrom
disable-retained-test-fulltext-indexes
Open

rbev wants to merge 1 commit into
masterfrom
disable-retained-test-fulltext-indexes

Conversation

@rbev

@rbev rbev commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Cloud tests retain schemas to avoid the schema-drop timeouts addressed by #6121. SQL Server also retains enabled full-text indexes, so completed tests can leave background indexing work competing with later tests.

The failing nightly run reported 31 full-text test failures and 871–967 in-progress population records. Retained populations are a suspected contributor; the logs do not establish the underlying blocker or show excessive index size.

When ServiceControl_TESTS_SKIP_SCHEMA_CLEANUP=true, SQL Server cleanup now disables only the completed test's full-text indexes. DISABLE stops ongoing populations and automatic updates while preserving schemas, tables, and data. Primary persistence defers this cleanup until after host disposal and uses an independent SQL connection. Normal schema dropping, PostgreSQL cleanup, production persistence, and test timeouts remain unchanged.

Disabling indexes still executes DDL and can encounter contention. It does not remove concurrent schema-creation or migration work. Restoring schema drops would reintroduce the original teardown workload; increasing timeouts would leave obsolete indexing work active.

Stop completed tests' full-text populations and automatic updates while retaining their schemas and data. Defer primary persistence index deactivation until the host is disposed, using an independent connection. Leave normal schema cleanup and PostgreSQL unchanged.

Verify schema isolation, retained data, repeated cleanup, quoted identifiers, normal drops, and host shutdown ordering. All four SQL Server suites pass locally with cleanup suppressed: 1,311 passed and two expected skips. The primary suite also passes with normal cleanup. PostgreSQL, RavenDB, and InMemory persistence test projects build without warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants