Repository navigation
Conversation
Stop completed tests' full-text populations and automatic updates while retaining their schemas and data. Defer primary persistence index deactivation until the host is disposed, using an independent connection. Leave normal schema cleanup and PostgreSQL unchanged. Verify schema isolation, retained data, repeated cleanup, quoted identifiers, normal drops, and host shutdown ordering. All four SQL Server suites pass locally with cleanup suppressed: 1,311 passed and two expected skips. The primary suite also passes with normal cleanup. PostgreSQL, RavenDB, and InMemory persistence test projects build without warnings.
johnsimons
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud tests retain schemas to avoid the schema-drop timeouts addressed by #6121. SQL Server also retains enabled full-text indexes, so completed tests can leave background indexing work competing with later tests.
The failing nightly run reported 31 full-text test failures and 871–967 in-progress population records. Retained populations are a suspected contributor; the logs do not establish the underlying blocker or show excessive index size.
When
ServiceControl_TESTS_SKIP_SCHEMA_CLEANUP=true, SQL Server cleanup now disables only the completed test's full-text indexes.DISABLEstops ongoing populations and automatic updates while preserving schemas, tables, and data. Primary persistence defers this cleanup until after host disposal and uses an independent SQL connection. Normal schema dropping, PostgreSQL cleanup, production persistence, and test timeouts remain unchanged.Disabling indexes still executes DDL and can encounter contention. It does not remove concurrent schema-creation or migration work. Restoring schema drops would reintroduce the original teardown workload; increasing timeouts would leave obsolete indexing work active.