Skip to content

Keep the endpoints on messages re-imported by --import-failed-errors - #6154

Open
warwickschroeder wants to merge 2 commits into
masterfrom
fix-import-failed-errors-endpoints
Open

warwickschroeder wants to merge 2 commits into
masterfrom
fix-import-failed-errors-endpoints

Conversation

@warwickschroeder

@warwickschroeder warwickschroeder commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What this fixes

ServiceControl.exe --import-failed-errors runs in its own host, which never registered the enricher that turns a message's NServiceBus.OriginatingEndpoint and ProcessingEndpoint headers into its sending and receiving endpoints.

Re-imported messages were stored with no endpoints, and ServicePulse, which renders every failed-message row with its receiving endpoint, then showed no rows at all in All Failed Messages or the message's group.

The import host now registers that enricher, so a re-imported message is stored exactly as normal ingestion stores it.

  • Re-imported messages keep their sending and receiving endpoints, name, host and host id, on every persister.
  • Endpoints seen only in re-imported messages are recorded as known endpoints, as normal ingestion does.
  • Docs: none needed; no page under docs/ describes --import-failed-errors or its host.

Tests

  • ServiceControl.AcceptanceTests/Recoverability/MessageFailures/When_failed_error_imports_are_imported_again.cs (new): the real import host re-imports a failed import and stores both endpoints, with host ids, and records both as known endpoints, on RavenDB, SQL Server and PostgreSQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants