Repository navigation
don't remove new EndpointDocuments due to throughput check - #6146
Open
PhilBastian wants to merge 11 commits into
Open
PhilBastian wants to merge 11 commits into
PhilBastian wants to merge 11 commits into
Conversation
… recent throughput check
This comment was marked as outdated.
This comment was marked as outdated.
andreasohlund
self-requested a review
November 17, 2026 14:43
…be used to prevent removal of entities that have only just been created but not yet populated with throughput
PhilBastian
requested review from
johnsimons,
rbev and
warwickschroeder
and
a balanced review from Copilot
November 18, 2026 04:26
PhilBastian
marked this pull request as ready for review
November 18, 2026 04:27
Contributor
Author
|
requested review from SQL persistence team to ensure the SQL migration is correct |
johnsimons
reviewed
Nov 18, 2026
|
|
||
| public string? Scope { get; set; } | ||
|
|
||
| public DateTime? CreatedDate { get; set; } |
Member
There was a problem hiding this comment.
Given that we haven't released EF, we probably should make this non nullable?
Contributor
Author
There was a problem hiding this comment.
won't that be confusing for future maintenance purposes if RavenDB and EF entities differ?
Member
There was a problem hiding this comment.
Not really, to me it is more correct given the direction we are going.
rbev
approved these changes
Nov 18, 2026
rbev
left a comment
Contributor
There was a problem hiding this comment.
Only did a quick review, but the EF migrations look fine to me.
johnsimons
reviewed
Nov 18, 2026
johnsimons
reviewed
Nov 18, 2026
johnsimons
reviewed
Nov 18, 2026
…ionedEndpointRemovalHostedService.cs Co-authored-by: John Simons <john.simons@particular.net>
…ionedEndpointRemovalHostedService.cs Co-authored-by: John Simons <john.simons@particular.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the EndpointDocument is new then don't remove it as part of the no recent throughput check
The decommissioned endpoints check has been moved out of the endpoint read and into its own hosted service. While this will no longer give an infallible list without any decommissioned endpoints, the difference of 1 day on the entire renewal period doesn't have a realistic impact
fixes #6142