[CHORE](ci) Remove legacy CodeArtifact publish step - #768
Merged
John McCall (lowlydba) merged 5 commits intoOct 1, 2026
Merged
Conversation
Consumers have cut over to MCD (OvertureMaps/ops-team#520), so the legacy publish-legacy job and ca-legacy credentials step in main-publish.yaml are no longer needed. The compute-version step now reads its index_url from a new ca-mcd credentials step (MCD read-only role for PR smoke tests, publish role for real pushes), and are-we-good's needs list drops publish-legacy. Closes #767 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
added
the
automation 🦾
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
John McCall (lowlydba)
marked this pull request as ready for review
September 30, 2026 20:18
John McCall (lowlydba)
requested review from
Alex Iannicelli (atiannicelli),
Seth Fitzsimmons (sethfitz) and
Victor Schappert (vcschapp)
and
a balanced review from Copilot
and removed request for
a team and
Copilot
September 30, 2026 20:18
Seth Fitzsimmons (sethfitz)
previously approved these changes
Sep 30, 2026
Consumers have cut over to MCD (OvertureMaps/ops-team#520), so the legacy publish-legacy job and ca-legacy credentials step in main-publish.yaml are no longer needed. The compute-version step now reads its index_url from a new ca-mcd credentials step (MCD read-only role for PR smoke tests, publish role for real pushes), and are-we-good's needs list drops publish-legacy. Closes #767 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
force-pushed
the
lowlydba-remove-legacy-codeartifact-publish
branch
from
October 1, 2026 13:48
3f3ad88 to
55d48da
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow change matches the stated cutover and its MCD smoke-test jobs passed.
Review effort: Balanced
Findings: None
What changed in this PR
Removes legacy CodeArtifact publishing while preserving version computation against MCD.
Changes:
- Replaces legacy credentials with MCD credentials.
- Removes the legacy publishing job.
- Updates the aggregate publish check dependency.
| File | Description |
|---|---|
.github/workflows/main-publish.yaml |
Publishes internal builds exclusively to MCD. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alex Iannicelli (atiannicelli)
previously approved these changes
Oct 1, 2026
Alex Iannicelli (atiannicelli)
left a comment
Alex Iannicelli (atiannicelli)
left a comment
Contributor
There was a problem hiding this comment.
lgtm
Seth Fitzsimmons (sethfitz)
previously approved these changes
Oct 1, 2026
…-remove-legacy-codeartifact-publish Signed-off-by: John McCall <john@overturemaps.org>
…y-codeartifact-publish # Conflicts: # .github/workflows/main-publish.yaml Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
dismissed stale reviews from Seth Fitzsimmons (sethfitz) and Alex Iannicelli (atiannicelli)
via
October 1, 2026 14:28
3f52e03
Drops the ops-team#520 cutover detail from the header comment per review feedback -- this will be revisited again in Phase 4, so keep the comment WIP-focused rather than documenting now-past state. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
requested review from
Alex Iannicelli (atiannicelli) and
Seth Fitzsimmons (sethfitz)
October 1, 2026 14:33
Seth Fitzsimmons (sethfitz)
approved these changes
Oct 1, 2026
Alex Iannicelli (atiannicelli)
approved these changes
Oct 1, 2026
Alex Iannicelli (atiannicelli)
left a comment
Alex Iannicelli (atiannicelli)
left a comment
Contributor
There was a problem hiding this comment.
clean
John McCall (lowlydba)
deleted the
lowlydba-remove-legacy-codeartifact-publish
branch
October 1, 2026 17:06
John McCall (lowlydba)
added a commit
to lowlysre/lowly-writing-framework
that referenced
this pull request
Oct 1, 2026
…update (#27) Merges the README's Install and Update sections under one `## Install and update` heading (Contents and the `docs/tutorial.md` link point at `#install-and-update`), and tightens the comment-convention rule in `references/docs-and-comments.md`. ## Why OvertureMaps/schema#768 had an agent rewrite a header comment that already cited `ops-team#466`. It swapped in `ops-team#562` and added "the legacy account's publish leg was removed once consumers cut over", which a reviewer flagged as documenting previous state. The "match the existing convention" bullet read as permission to copy the old comment's pattern. - The bullet now covers form only, and says a comment that breaks the other rules isn't precedent - A new bullet covers comments on removed or replaced code: describe the new behavior, drop the old ref - `evals/code-comment-removal-existing-ref.json` covers the removal-with-existing-ref case, which `code-comment-present-tense.json` doesn't ### Token trims - `SKILL.md`'s five separate "trigger" bullets are merged into one list with the same triggers and tool names - A few clauses in `docs-and-comments.md` and `body-writing.md` are shortened ## Testing Ran `code-comment-removal-existing-ref.json` by hand against this checkout with a fresh agent: it wrote `# Publishes to the registry.`, which meets all four `expected_behavior` items. The other evals weren't re-run; the trims move wording only and no rule text. `npm run tokens`: activation ~2,770, on demand ~20,060. <!--:robot:--> --------- Signed-off-by: John McCall <john@overturemaps.org>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the legacy CodeArtifact publish leg from
main-publish.yamlso internal builds publish to the MCD account only. The pypi consumer cutover (OvertureMaps/ops-team#520) is complete, so the dual-publish groundwork from OvertureMaps/ops-team#466 is no longer needed.Beyond the
publish-legacyjob itself,ca-legacy's CodeArtifact credentials also fed thecompute-versionstep's index lookup. Removingca-legacyoutright would have broken version computation, so this replaces it with an equivalentca-mcdstep: the existing dedicated MCD read-only role for the PR smoke test, and the existing MCD publish role for real pushes (same pattern already proven in #747).Closes #767
Reference
Testing
main-publish.yamlalso runs read-only on any PR that touches itself, as a smoke test for this exact wiring. On this PR,Detect affected packages (test), every per-packageBuild <package> (test)job, andAre we good?all passed, confirmingcompute-versionresolves correctly against the newca-mcdstep.Checklist
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Note
This is a CI-only workflow change with no schema content, so the checklist above doesn't apply.
Documentation website
Docs preview for this PR.