Repository navigation
Conversation
The Liberty 5 has no transparency sub-mode. The third sound-mode byte is an In-Call Sound Awareness toggle, so expose it as a boolean instead of a TransparencyMode selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Liberty 5 has no transparency sub-mode; captured state updates show this byte is the In-Call Sound Awareness toggle.
This maps it to a boolean, exposes Sound Modes -> In-Call Sound Awareness, and sends it through the existing
[6, 129]sound-mode packet.Verification
[6, 129]with the third sound-mode byte set to1.cargo test -p openscq30-lib --libpasses (208 tests).cargo fmt --all -- --checkpasses.Impact
This removes the incorrect
Transparency Modesetting for A3957. Quick presets that referenceTransparencyModefor this device will no longer apply.InCallSoundAwarenessis appended toSettingIdso existing preset IDs remain stable.