Repository navigation
[#256] Match "OpenIDM ready" as a phrase in the Windows start-up check - #257
Merged
vharseko merged 1 commit intoOct 13, 2026
Conversation
…indows start-up check findstr without /C: treats space-separated words as alternatives, so `findstr "OpenIDM ready"` matched any line containing "OpenIDM" -- and openidm0.log.0 always contains the install path -- letting a boot that never got ready pass. Use Select-String -SimpleMatch -CaseSensitive, matching the Unix grep, and drop the incorrect $LASTEXITCODE comment. Fixes OpenIdentityPlatform#256
vharseko
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findstr "OpenIDM ready"without/C:treats the space-separated words as alternatives, so it matched any line containing "OpenIDM" — andopenidm0.log.0always contains the install path. A Windows boot that never logged "OpenIDM ready" therefore passed "Test on Windows" (e.g. windows-latest/27 in run 38152659213).The check now uses
Select-String -SimpleMatch -CaseSensitive, matching the exact phrase like the Unixgrep -q. The$LASTEXITCODEcomment, whose premise was wrong (the runner already exits with$LASTEXITCODEat the end of every pwsh step), is replaced with the reasonfindstris not used.Fixes #256