Repository navigation
Exclude static fields from field query maps - #3613
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a query-map DTO declares non-null static fields such as serialVersionUID or a class constant, FieldQueryMapEncoder currently adds those fields to the request query. The same happens for inherited static fields and static fields with @PARAM aliases.
Exclude static fields during metadata discovery before making fields accessible. Instance fields, inherited instance fields, @PARAM names, null omission and cached re-encoding keep their existing behavior.
Validation: the two added regressions fail on unchanged master, showing the leaked static keys. With the patch, all 774 reported core tests complete with zero failures/errors and 4 skips (770 executed); Maven core verify passes with the dev profile, formatting and license checks enabled. Validation used JDK26 in an independent checkout of the same master commit, with the two submitted files copied back and checked byte-for-byte. Other integration modules were not run.
AI assistance: DeepSeek and Codex assisted implementation, tests and review; the full patch and actual validation were checked before submission.