Repository navigation
Feature 320 atid #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature 320 atid #322
Changes from all commits
4c9d0c1
a7f828c
60881d2
f7470cb
22ad746
64a0bcd
83d8d72
e93f6b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| "readOnly": true | ||
| }, | ||
| "@id": { | ||
| "description": "A unique identifier (UUID/DOI) for the collection.", | ||
| "description": "A unique identifier (UUID/DOI) for the dataset. This is the Databus Artifact.", | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
|
|
@@ -30,6 +30,18 @@ | |
| "format": "uri", | ||
| "readOnly": true | ||
| }, | ||
| "path": { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This compares to the previous How would this be filled for datasets that are neither on the databus nor the OEP? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess we need to modify the context.json as well if we add the new path property here. Path currently has several definitions depending on the nested context: If we have at least one "id" and "path" in that regard. I am not 100% sure what happens if we identify one of them as alias for |
||
| "description": "A unique identifier for the dataset.", | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "examples": [ | ||
| "https://openenergyplatform.org/database/tables/oemetadata_table_template" | ||
| ], | ||
| "badge": "Bronze", | ||
| "title": "Dataset Name" | ||
| }, | ||
| "name": { | ||
| "description": "A filename or database conform dataset name.", | ||
| "type": [ | ||
|
|
@@ -82,7 +94,7 @@ | |
| "badge": "Silver", | ||
| "title": "Dataset Extent Name" | ||
| }, | ||
| "@id": { | ||
| "id": { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The context.json currently only has this definition for "id" (it is in the global scope): I assume we rather need to alias it now: "id": "@id" Also I did not found any occurrence of a mere "id" field (without the @) in the previous schema.json so maybe the above can simply be replaced without further issues. |
||
| "description": "A URI reference for the region of the dataset.", | ||
| "type": [ | ||
| "string", | ||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also modify this id field?