Repository navigation
Handle DocFX exit codes in BuildCommand - #19
Merged
Merged
Conversation
- Change Utils.RunCommand return type from Task to Task<int> to return process exit code - Capture exit code from DocFX command in BuildCommand - Check if exit code is non-zero and skip further processing if DocFX fails - Log error message with exit code when DocFX fails Fixes: Extract changes from PR #9 Co-authored-by: bdovaz <950602+bdovaz@users.noreply.github.com>
Copilot
AI
changed the title
fix: Handle DocFX exit codes in BuildCommand
Handle DocFX exit codes in BuildCommand
Oct 15, 2026
bdovaz
marked this pull request as ready for review
October 15, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocFX failures were silent because
RunCommanddidn't return the process exit code. A non-zero exit meant the caller had no way to detect failure without checking file existence afterward—a weak, delayed signal.Changes
Task<int>instead ofTaskto surface the exit codeThis makes DocFX errors visible at the point of failure rather than relying on downstream checks. The version is now skipped immediately with a clear error log.
Note: This extracts a focused fix from a larger PR to isolate exit code handling from unrelated changes (regex and pagination fixes).