Repository navigation
[fpmp] Shorter fp32mp2 math kernels at the low and default levels, mostly #12641's at high #12646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rmlarsen
wants to merge
60
commits into
NVIDIA:main
Choose a base branch
from
rmlarsen:fpmp-level-kernels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13,436
−3,464
Open
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
780d446
[fp] fp32mp2 exp to 46 bits, with gradual underflow
akolesov-nvidia 768c92c
[fp] fp32mp2 exp2/exp10/log family to 45-48 bits
akolesov-nvidia 4e6760c
[fp] fp32mp2 trig family to 45-46 bits
akolesov-nvidia 6a8d944
[fp] fp32mp2 asin/acos/atan/atan2 to 46-48 bits; more accurate sqrt
akolesov-nvidia 951d44b
[fp] fpmp2 sqrt/rsqrt: new forms for fp32mp2 only
akolesov-nvidia 770adfa
[fp] fpmp2 exp: split the fp32mp2 kernel for reuse by pow
akolesov-nvidia 4f15d72
[fp] fp32mp2 pow: more accurate exponent argument
akolesov-nvidia 8aed553
[fp] fp32mp2 cbrt/rcbrt to 47 bits, native fp32mp2 hypot/rhypot
akolesov-nvidia d733a69
[fp] fp32mp2 sinh/tanh/atanh to 46 bits; overflow and domain fixes
akolesov-nvidia 5b22aed
[fp] fp32mp2 fdim, remquo, lrint/lround/llrint/llround exact on the p…
akolesov-nvidia 812b308
[fp] fpmp2 classification predicates look at both limbs
akolesov-nvidia 8f2acb9
[fp] fp32mp2 erfc/boys_f0/normcdfinv to 45-46 bits; native erfcx, nor…
akolesov-nvidia 3e30040
[fp] fp32mp2 normcdfinv: tests for p at the ends of (0, 1)
akolesov-nvidia 22d3ed7
fpmp: fp32mp2 fmod exact on every pair; remainder and remquo exact in…
akolesov-nvidia 1fad94f
[fp] fp32mp2 math kernels: pass scalars as scalars, double with * 2.0f
akolesov-nvidia 62eb7ab
[fp] fp32mp2 math: IEEE special values for log/log2/log10, atan, the …
akolesov-nvidia 2f4e054
[docs][fp] fpmp: sqrt and rsqrt take no branch for special arguments
akolesov-nvidia 8262859
[fp] fpmp: unit test for the math special values
akolesov-nvidia b9b8100
[docs][fp] fpmp: the sign of zero is not tracked
akolesov-nvidia 04645e0
[fp] fp32mp2 pow: take the triple-float implementation of PR #12548
akolesov-nvidia e748bb2
[fp] fp32mp2 rsqrt: keep the single-step form of main
akolesov-nvidia 9e9823e
[fp] fp32mp2 trig reduction: take the fast-path accumulation of #12530
akolesov-nvidia c48460e
[fp] fpmp math: clang-format
akolesov-nvidia 151aea0
Merge branch 'main' into dev/akolesov/fp32mp2_math_update
akolesov-nvidia 878a2af
[fp] fp32mp2 math: special-value fixes from the review of #12641
akolesov-nvidia 804f016
[fp] fpmp: the special-values test covers the review's gaps
akolesov-nvidia 0abc63d
[docs][fp] fpmp: what the reduction, sqrt, the remainder family and t…
akolesov-nvidia 8989bc7
[fp] fpmp: CI fixes: unused variable in sqrt, fast-math builds skip t…
akolesov-nvidia c330b4c
[fp] fpmp math: contraction-proof products in the refined division an…
akolesov-nvidia 1a71773
[fpmp] CI override: run the cuda/fp unit tests on sm_75 and sm_90 [re…
rmlarsen 07f38af
[fpmp] CI override: name CTK 12.X's compilers
rmlarsen bc4efdd
[fpmp] Keep GCC from contracting the products of div_refined and the …
rmlarsen 5f9a1d2
[fpmp] Seed the host fp32mp2 cbrt and rcbrt with a refined polynomial
rmlarsen 8cd5af7
[fpmp] fp32mp2 erfc: return exactly 0 or 2 beyond the underflow thres…
rmlarsen dc3026b
[fpmp] fp32mp2 sin, tan and sincos: return -0 for -0
rmlarsen e1e3b14
[fpmp] fp32mp2 asin, acos, atan and atan2: handle their special value…
rmlarsen 6104e09
[fpmp] fp32mp2 exp2, expm1, log1p, sinh, tanh and atanh: fix special …
rmlarsen 4a2e288
[fpmp] Evaluate the fp32mp2 erfc kernel with one reciprocal and a ref…
rmlarsen 21169b5
[fpmp] Reduce and evaluate fp32mp2 sin, cos and tan in fewer operatio…
rmlarsen decbde0
[fpmp] Evaluate fp32mp2 asin, acos, atan and atan2 on one table-drive…
rmlarsen d9cffbd
[fpmp] Evaluate the fp32mp2 exp and log families on the tables of pow
rmlarsen 038de85
[fpmp] Evaluate the fp32mp2 hyperbolic functions on the exp and log k…
rmlarsen 7f2435f
[fpmp] fpmp2 norms, fmax, fmin and fdim: fix special operands
rmlarsen 589756c
[fpmp] Give fpmp2 sqrt and rsqrt a second-order kernel at high accura…
rmlarsen 80204a9
Merge branch 'main' into fpmp-cbrt-host-seed
rmlarsen 0013716
Merge branch 'main' into fpmp-level-kernels
rmlarsen ff85322
Merge NVIDIA/cccl#12641 (c330b4cd14) into fpmp-cbrt-host-seed
rmlarsen dc07be9
[fpmp] fp32mp2 erfcinv: form the far-tail seed with explicit fmas
rmlarsen 74c1c68
Merge branch 'fpmp-cbrt-host-seed' into fpmp-level-kernels
rmlarsen dc90ca8
[fpmp] fp32mp2 sinpi, cospi, erf and erfinv: fix the sign of zero res…
rmlarsen 0d3de05
[fpmp] Evaluate fp32mp2 erfcx and normcdf on the one-reciprocal erfc …
rmlarsen ec68e67
[fpmp] fp32mp2 llrint, llround, erfcx, exp_scales and the zero-sign s…
rmlarsen 02b1d83
Merge the review fixes of #12568 (ec68e67665) into fpmp-level-kernels
rmlarsen 1ce07a9
[fpmp] fpmp2 zero-argument shortcuts: test both limbs
rmlarsen 5a9b39b
Merge the zero-argument fix of #12568 (1ce07a92bc) into fpmp-level-ke…
rmlarsen ec0800b
[fpmp] fp32mp2 sinh: clamp the reciprocal's divisor; fmax, fmin: orde…
rmlarsen 62496ed
Merge #12568 (ec0800be1a) into fpmp-level-kernels; leave the subnorma…
rmlarsen 0441ab8
[fpmp] fp32mp2_low expm1, log1p, sinh, tanh, asinh, atanh: renormaliz…
rmlarsen 0f5132d
[fpmp] fp32mp2 atanh, erfinv and atan2: loose pairs of low-accuracy a…
rmlarsen d6c3395
Merge #12568 (0f5132d95b) into fpmp-level-kernels: the low-accuracy p…
rmlarsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
important: Clear the temporary override before merging.
These entries replace the normal
pull_requestmatrix. Lines 67-69 explicitly state that this mode makes branch-protection checks fail. Remove the temporary entries after targeted validation, but retain theoverride:key.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: the override is there while this stack is in draft iteration and is reset to an empty
override:before merging.