Skip to content

CI: daemonize-next migration - #2

Closed
MohibShaikh wants to merge 1 commit into
mainfrom
daemonize-next
Closed

MohibShaikh wants to merge 1 commit into
mainfrom
daemonize-next

Conversation

@MohibShaikh

Copy link
Copy Markdown
Owner

Runs the CI matrix on the migration branch before proposing it upstream.

daemonize 0.5 is unmaintained (RUSTSEC-2025-0069). daemonize-next keeps its
API, so only the dependency line changes, and it drops root's supplementary
groups when switching user and reports a failed start in the launcher.

The default daemon user and group were "onbody", which does not exist, so
with no daemon_user configured the user lookup failed after the fork, the
error was only logged, and the server kept running as root. Default to
nobody, take the group from the user when daemon_group is empty, and return
the error when daemonizing fails.
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5fc0ee2b-0192-4169-b770-1fc13df41b29
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MohibShaikh

Copy link
Copy Markdown
Owner Author

Fork-only CI run; results are in Tongsuo-Project#145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant