Skip to content

Replace bundled rsync with a clonetool based copy_tool - #3323

Merged
aaronsky merged 3 commits into
MobileNativeFoundation:mainfrom
john-flanagan:jflan/copy-tool
Oct 21, 2026
Merged

aaronsky merged 3 commits into
MobileNativeFoundation:mainfrom
john-flanagan:jflan/copy-tool

Conversation

@john-flanagan

Copy link
Copy Markdown
Contributor

Take advantage of APFS clones when copying files out of the Bazel output base.

Also breaks our dependency on either system or bundled rsync.

@john-flanagan
john-flanagan requested review from a team as code owners July 29, 2026 21:55
Comment thread xcodeproj/internal/bazel_integration_files/copy_tool.py
Comment thread xcodeproj/internal/templates/installer.sh Outdated
Comment thread xcodeproj/internal/bazel_integration_files/BUILD Outdated
Comment thread xcodeproj/internal/bazel_integration_files/copy_tool.py Outdated
Comment thread xcodeproj/internal/bazel_integration_files/copy_tool.py Outdated
Comment thread xcodeproj/internal/bazel_integration_files/copy_tool.py

@aaronsky aaronsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine but I haven't tested it on our project yet. Approving to unblock CI.

@brentleyjones

Copy link
Copy Markdown
Contributor

@john-flanagan Can you rebase this?

Signed-off-by: John Flanagan <github@jflan.com>
Use py_binary to run copy_tool
Add unit tests and type annotations

Signed-off-by: John Flanagan <github@jflan.com>
@brentleyjones
brentleyjones enabled auto-merge (squash) October 15, 2026 13:43
@aaronsky
aaronsky disabled auto-merge October 21, 2026 13:03
@aaronsky
aaronsky merged commit 85cecf5 into MobileNativeFoundation:main Oct 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants