Repository navigation
Conversation
added 4 commits
October 23, 2026 21:15
…splay Keep display capture as the default, and end the session when the selected window or application disappears.
Give the encoder a blank frame instead of opening a second ScreenCaptureKit stream, and allow saving an app that has no cover image.
…hanges Capture that window independently of the current desktop, so switching spaces does not change the stream.
Saving stopped when the image path was missing. Omit the empty path so the existing initial-letter placeholder remains.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| TEST(CaptureSourceTest, AppsJsonSelectsWindowCapture) { | ||
| const auto path = std::filesystem::temp_directory_path() / "sunshine_capture_source_apps.json"; |
| std::copy_n(audio_samples.begin(), needed, source.begin()); | ||
| audio_samples.erase(audio_samples.begin(), audio_samples.begin() + static_cast<std::ptrdiff_t>(needed)); | ||
| const auto produced = produced_audio; | ||
| lock.unlock(); |
flashboss
changed the title
flashboss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saving an application with no image used to stop, so nothing was stored. The save now goes through. No new cover is created: the app keeps the initial letter already shown in the list.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Type of Change
Checklist
AI Usage
See our AI usage policy.