Repository navigation
fix(audit): impedir overflow na soma de liquidações - #31
Draft
vitormattos wants to merge 1 commit into
Draft
vitormattos wants to merge 1 commit into
vitormattos wants to merge 1 commit into
Conversation
Prevent integer-to-float promotion when summing linked payments; retain conservative uncertainty handling and cover the limit with a synthetic regression. Refs #8 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
A regra
document_settlementsomava pagamentos com+=, podendo converter centavos inteiros emfloatem um limite extremo. Um achado gerado com essa evidência quebrava o contrato tipado deOccurrence.Correção
CheckedCents::addpara acumular pagamentos vinculados.insufficient(unsupported_payments), sem afirmar divergência financeira.Refs #8.
Evidências executadas
unsupported_paymentscom classificaçãoinsufficient(exit 0).php -ldos dois arquivos egit diff --check: aprovados.Limitações e revisão