Skip to content

Core: Replace header guards with #pragma once, remove unused includes - #11681

Merged
WinterSolstice8 merged 2 commits into
LandSandBoat:basefrom
sruon:sruon/header_cleanup
Oct 2, 2026
Merged

WinterSolstice8 merged 2 commits into
LandSandBoat:basefrom
sruon:sruon/header_cleanup

Conversation

@sruon

@sruon sruon commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Time to clean-up the C++ code and make it more consistent.

Starting simple:

  • Convert to #pragma once
  • Drop unused headers

Next steps will include:

  • Reducing the headers we pull in, in a few places
  • Introducing std::ranges/std::erase_if where possible
  • Replacing ternaries
  • Getting rid of C casts
  • Standardizing on dynamic_cast for type checks
  • Replacing enums with scoped enums
  • @zach2good will probably add to the list

Steps to test these changes

@WinterSolstice8
WinterSolstice8 merged commit 49c3222 into LandSandBoat:base Oct 2, 2026
14 checks passed
@zach2good

Copy link
Copy Markdown
Contributor

Excellent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants