Skip to content

chore(deps): upgrade vitest to 5.0.3 - #3674

Merged
finetjul merged 1 commit into
Kitware:masterfrom
daker:fix-chromium-tests
Oct 5, 2026
Merged

finetjul merged 1 commit into
Kitware:masterfrom
daker:fix-chromium-tests

Conversation

@daker

@daker daker commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Context

Tests suite is failing with :

Error: Failed to run the test /home/runner/work/vtk-js/vtk-js/Sources/Interaction/Style/InteractorStyleTrackballCamera/test/testMouseWheel.js.
 ❯ node_modules/vitest/dist/chunks/cli-api.BK8pd4xc.js:2638:17

Caused by: Error: [vitest] Browser connection was closed while running tests. Was the page closed unexpectedly?
 ❯ WebSocket.<anonymous> node_modules/@vitest/browser/dist/index.js:3054:16
 ❯ WebSocket.emit node:events:531:35
 ❯ WebSocket.emitClose node_modules/ws/lib/websocket.js:279:10
 ❯ Socket.socketOnClose node_modules/ws/lib/websocket.js:1360:15
 ❯ Socket.emit node:events:531:35
 ❯ TCP.<anonymous> node:net:347:12
 ❯ TCP.callbackTrampoline node:internal/async_hooks:130:17

Caused by: Error: [birpc] rpc is closed, cannot call "createTesters"
 ❯ node_modules/@vitest/browser/dist/index.js:2915:34
 ❯ Proxy.$close node_modules/@vitest/browser/dist/index.js:2914:18
 ❯ WebSocket.<anonymous> node_modules/@vitest/browser/dist/index.js:3054:9
 ❯ WebSocket.emit node:events:531:35
 ❯ WebSocket.emitClose node_modules/ws/lib/websocket.js:279:10
 ❯ Socket.socketOnClose node_modules/ws/lib/websocket.js:1360:15
 ❯ Socket.emit node:events:531:35
 ❯ TCP.<anonymous> node:net:347:12

Results

Tests suite don't fail anymore

Changes

Vitest 5 forces a Chromium GC when disk space is low (vitest-dev/vitest#10912). This stops the CI crashes from leaked shared memory.

PR Checklist

  • GitHub Actions CI passed: semantic-release commit messages, lint, and tests
  • Test coverage added
  • Documentation and TypeScript definitions are updated to match these changes

Vitest 5 forces a Chromium GC when disk space is low (vitest-dev/vitest#10912).
This stops the CI crashes from leaked shared memory.

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul
finetjul added this pull request to the merge queue Oct 5, 2026
Merged via the queue into Kitware:master with commit 475f0b8 Oct 5, 2026
4 checks passed
@daker
daker deleted the fix-chromium-tests branch October 5, 2026 16:19
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 37.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released Automated label label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants