Skip to content

perf(ViewNode): find direct children in getViewNodeFor - #3673

Open
daker wants to merge 1 commit into
Kitware:masterfrom
daker:perf-scenegraph
Open

daker wants to merge 1 commit into
Kitware:masterfrom
daker:perf-scenegraph

Conversation

@daker

@daker daker commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Context

Results

Changes

getViewNodeFor looks in the renderable to child map before it searches the children recursively, so a direct child is found without a walk of the tree.

PR Checklist

  • GitHub Actions CI passed: semantic-release commit messages, lint, and tests
  • Test coverage added
  • Documentation and TypeScript definitions are updated to match these changes

getViewNodeFor looks in the renderable to child map before it searches
the children recursively, so a direct child is found without a walk
of the tree.
@daker

daker commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator Author

@PaulHax @finetjul FYI

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants